I upgraded when the M3 was cutting edge. First, the suggestion that you go with an M5 Max as baseline is solid. I opted for 64GB memory and still consider that a minimum. I’ve actually run out of memory on occasion, but you did say that you wanted to future proof. 1TB is a serious limitation. The good news is that adding expensive Thunderbolt 5 external SSD can be quite helpful, but it still isn’t up to the same speed as the internal drive. Honestly, on my next system I’ll go for 4 TB internal. Apple memory is very expensive, but external isn’t exactly a best buy. Performance, in this SSD shortage environment is very expensive, but you don’t get a second shot at getting this right. Personally, I would wait until the dual OLED touch screen MacBooks come to market. Perhaps, we will even start to see some relief from the high memory prices sometime in 2027. Keep you eyes on the September Apple event.
I use LRC, so don’t know how your photo editor uses resources, but Adobe continues to add “AI” photo editing features that are heavily GPU dependent and recently tweaked for Apple silicon, so another aspect of future proof might involve a bump up in GPU count..